docs: guard cache usage in cache fixture example#14269
Closed
kartikdp wants to merge 2 commits intopytest-dev:mainfrom
Closed
docs: guard cache usage in cache fixture example#14269kartikdp wants to merge 2 commits intopytest-dev:mainfrom
kartikdp wants to merge 2 commits intopytest-dev:mainfrom
Conversation
Author
|
All checks are green; ready for review. |
Author
|
Thanks for reviewing. I noticed this overlaps with #14254, which was opened earlier and is already in review, so I’m closing this one as a duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a docs bug in the cache example.
The example in
doc/en/how-to/cache.rstaccessedpytestconfig.cachedirectly, which can raise
AttributeErrorwhen thecacheproviderplugin isdisabled (for example, with
-p no:cacheprovider).The fixture example now:
getattr(pytestconfig, "cache", None)cachevariable forget/setcloses #14148
Impact
configurations.
How tested
uv run --with tox tox -e docsChecklist
behavior)
applicable: docs-only fix)
closes #XYZWto PR description and/or commits.Co-authored-bycommittrailers.
changelog(not required for this smalldocs fix).
AUTHORS(not required for this small docs fix).