Avoid traceback formatting for xfail(run=False)#14780
Open
ace2016 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9436.
Summary
Tests marked with
xfail(run=False)stop before execution by raising pytest'sinternal xfail exception. That exception previously used
pytrace=True, soreport generation formatted a full traceback even though the xfail report only
displays the
[NOTRUN]reason.Raise the same internal exception with
pytrace=Falsein both the setup pathand the dynamically evaluated call path. This uses pytest's existing
value-only outcome formatting and leaves imperative
pytest.xfail(), normalfailures, and the report pipeline unchanged.
A regression test verifies that
xfail(run=False)requests value-onlyformatting instead of long traceback formatting.
Testing
python -m pytest -p no:asyncio testing/test_skipping.py testing/test_reports.py -qand mypy.
git diff --checkpassed.Checklist
Not applicable because this is an internal performance improvement.
Closes #9436to the PR description.Co-authored-bycommit trailers.changelog/9436.improvement.rst.AUTHORSin alphabetical order.