Fix uniq comparisons across hashability paths#1514
Conversation
Compare fallback values against values handled by the structural hash. Add regression coverage for both input orderings.
|
Hi there -- such values aren't possible to encounter in JSON as far as I can tell from your patch. Is there some actual user-facing bug you see via this path (i.e. a schema)? If so we'd at least want to test via that. |
|
@Julian You're right. I traced the complete I could not produce a schema-level user-facing case, so I'm withdrawing this PR rather than expanding |
uniq()could report equal values as unique when one uses the structural-hash path and the other falls back to pairwise comparison (for example,setandfrozenset). Compare fallback values across both paths so the result no longer depends on input order.