Embed SBOM into wheels#9679
Open
hugovk wants to merge 2 commits into
Open
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
radarhere
reviewed
Jun 20, 2026
Comment on lines
+82
to
+83
| print(f"error: no wheels found in {args.wheelhouse}", file=sys.stderr) | ||
| raise SystemExit(1) |
Member
There was a problem hiding this comment.
Suggested change
| print(f"error: no wheels found in {args.wheelhouse}", file=sys.stderr) | |
| raise SystemExit(1) | |
| parser.error(f"no wheels found in {args.wheelhouse}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on from #9550, which generates an SBOM and uploads it to a GitHub release.
This PR embeds the SBOM into the
.dist-info/sboms/directory of wheels, following PEP 770.Things to note:
The Linux wheels already contain an SBOM,
auditwheel.cdx.json, created by auditwheel during the manylinux repair step of cibuildwheel.auditwheel.cdx.jsonuses CycloneDX 1.4, and varies for each generated wheel.Our own SBOM uses CycloneDX 1.7, and is identical for all wheels, and include all our deps, based on our
dependencies.json. We don't vary per OS.To inspect: download a wheel, rename to
.zip, look inpillow-12.3.0.dev0.dist-info/sboms/.Should we include our own generated SBOM in the wheel?
Should we keep the
auditwheel.cdx.jsonSBOM?Multiple SBOMs are allowed in the dir, and they do both describe the distribution, in different ways.
cc @jkowalleck @sethmlarson