fix: correct misplaced parenthesis in item() sort key#554
Closed
muhamedfazalps wants to merge 1 commit into
Closed
fix: correct misplaced parenthesis in item() sort key#554muhamedfazalps wants to merge 1 commit into
muhamedfazalps wants to merge 1 commit into
Conversation
The sort key lambda for dict-valued list items had a misplaced parenthesis: the isinstance(i[1], dict) check was applied even when _sort_keys=False, causing dict-valued keys to be silently reordered after scalar-valued keys regardless of the sort_keys setting. Fix: guard the entire sort tuple with _sort_keys, matching the existing pattern used for top-level dicts (line 146). Fixes python-poetry#546.
Contributor
|
this was wrong at #547 and is still wrong here |
Author
|
You're right @dimbleby — the dictionaries-last ordering is intentional capture-avoidance (scalar keys must render before sub-table headers to prevent capture). Making it conditional on sort_keys breaks that invariant. This PR is wrong, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #546
Corrected a misplaced parenthesis in the sort key lambda for dict-valued list items. All 355 tests pass.