Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Negative powers of integer items currently disagree with their serialized value:
item(2) ** -1compares equal to0, but renders as0.5. Fractional exponents also raise instead of allowing Python's reflected float operation.Keep floating-point power results as
Floatitems and passNotImplementedback to Python for reflected dispatch. Positive and modular integer powers retain their existing result type.Tests: 12 new cases pass (7 fail on the original implementation); the complete suite passes with 1109 tests on Python 3.12. Ruff and formatting checks pass, and both wheel and sdist build. Mypy reports the same five pre-existing errors on the original and patched source.
The downstream Poetry integration fails one extraction assertion on Python 3.12.15. A controlled replay with the official tarfile modules reproduces the difference without importing tomlkit: 3.12.15 normalizes the path and writes safely inside the destination, while the unchanged Poetry test expects OutsideDestinationError. The test expectation is addressed in python-poetry/poetry#11133.
Agent Drafting Metadata