Skip to content

gh-76075: Correct datetime.timestamp documentation - #131202

Merged
pganssle merged 3 commits into
python:mainfrom
StanFromIreland:mktime-doc
May 20, 2025
Merged

gh-76075: Correct datetime.timestamp documentation#131202
pganssle merged 3 commits into
python:mainfrom
StanFromIreland:mktime-doc

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Mar 13, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Mar 13, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Mar 13, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 13, 2025
Closed
@StanFromIreland

StanFromIreland commented May 19, 2025

Copy link
Copy Markdown
Member Author

@pganssle Friendly ping, maybe you could review ... ?

pganssle
pganssle requested changes May 20, 2025
View reviewed changes
Comment thread Doc/library/datetime.rst
@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland

StanFromIreland commented May 20, 2025

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

@bedevere-app
bedevere-app Bot requested a review from pganssle May 20, 2025 15:57
pganssle
pganssle requested changes May 20, 2025
View reviewed changes

@pganssle pganssle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, minor nitpick.

Comment thread Doc/library/datetime.rst Outdated
@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland

StanFromIreland commented May 20, 2025

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

@bedevere-app
bedevere-app Bot requested a review from pganssle May 20, 2025 16:09
pganssle
pganssle approved these changes May 20, 2025
View reviewed changes

@pganssle pganssle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Stan!

@pganssle
pganssle merged commit 86397cf into python:main May 20, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs May 20, 2025
@StanFromIreland
StanFromIreland deleted the mktime-doc branch May 20, 2025 16:21
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@StanFromIreland @lkollar
pythongh-76075: Correct datetime.timestamp documentation (python#13…
31ba909 
…1202)

* Clean up timestamp docs

* Update datetime.rst

* Suggestion
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@StanFromIreland @Pranjal095
pythongh-76075: Correct datetime.timestamp documentation (python#13…
d76817f 
…1202)

* Clean up timestamp docs

* Update datetime.rst

* Suggestion
@brianschubert

brianschubert commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

Do we want this backported to 3.13/3.14?

@brianschubert brianschubert mentioned this pull request Jul 16, 2025
Closed
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@StanFromIreland @taegyunkim
pythongh-76075: Correct datetime.timestamp documentation (python#13…
2747801 
…1202)

* Clean up timestamp docs

* Update datetime.rst

* Suggestion
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 6, 2026
@miss-islington-app

miss-islington-app Bot commented Aug 6, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @pganssle for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Aug 6, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @pganssle for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Aug 6, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland and @pganssle, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 86397cf65d024a39ae85b81d7f611ad4864a78b4 3.13

@miss-islington-app

miss-islington-app Bot commented Aug 6, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland and @pganssle, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 86397cf65d024a39ae85b81d7f611ad4864a78b4 3.14

@bedevere-app

bedevere-app Bot commented Aug 6, 2026

Copy link
Copy Markdown

GH-155284 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Aug 6, 2026
@bedevere-app

bedevere-app Bot commented Aug 6, 2026

Copy link
Copy Markdown

GH-155285 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 6, 2026
serhiy-storchaka added a commit that referenced this pull request Aug 6, 2026
@serhiy-storchaka @StanFromIreland
[3.14] gh-76075: Correct datetime.timestamp documentation (GH-131202)…
4e87f4e 
… (GH-155285)

(cherry picked from commit 86397cf)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
serhiy-storchaka added a commit that referenced this pull request Aug 6, 2026
@serhiy-storchaka @StanFromIreland
[3.13] gh-76075: Correct datetime.timestamp documentation (GH-131202)…
15daa2f 
… (GH-155284)

(cherry picked from commit 86397cf)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle pganssle approved these changes
@abalkin abalkin Awaiting requested review from abalkin

Assignees

@pganssle pganssle

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland @brianschubert @pganssle @serhiy-storchaka