Skip to content

Remove mention of 'Unicode' strings in documentation#136215

Open
Viicos wants to merge 1 commit into
python:mainfrom
Viicos:json-unicode-strings
Open

Remove mention of 'Unicode' strings in documentation#136215
Viicos wants to merge 1 commit into
python:mainfrom
Viicos:json-unicode-strings

Conversation

@Viicos
Copy link
Copy Markdown
Contributor

@Viicos Viicos commented Jul 2, 2025

This was written when Python 2 was still relevant, so I think we can remove the explicit 'Unicode' mention here.


📚 Documentation preview 📚: https://cpython-previews--136215.org.readthedocs.build/

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 26, 2026
@serhiy-storchaka
Copy link
Copy Markdown
Member

But this was written only for Python 3. Other programming languages can have 8-bit strings, and other Python libraries can serialize to bytes objects. So I think it will not harm to highlight that the json module works with Unicode strings.

@serhiy-storchaka serhiy-storchaka added the pending The issue will be closed if no feedback is provided label May 31, 2026
@Viicos
Copy link
Copy Markdown
Contributor Author

Viicos commented May 31, 2026

But this was written only for Python 3.

According to the blame, it was for 2.7? But fair enough, I think we can leave it as is.

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jun 1, 2026
@serhiy-storchaka
Copy link
Copy Markdown
Member

Note that it says "Unicode strings", but refers to str, which is not an Unicode string in Python 2.
The latest version does not contain such text. The logs for Doc/library/json.rst don't contain such change. The real change was in f3e0a69 which does not contain such passage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir pending The issue will be closed if no feedback is provided skip issue skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants