Skip to content

gh-142781: Fix type confusion in zoneinfo weak cache #142925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
superboy-zjc wants to merge 6 commits into
base: main
Choose a base branch
from
Open

gh-142781: Fix type confusion in zoneinfo weak cache #142925

superboy-zjc wants to merge 6 commits into from

Conversation

@superboy-zjc
Copy link
Contributor

@superboy-zjc superboy-zjc commented Dec 18, 2025

Validate the types returned from _weak_cache.get() and _weak_cache.setdefault() to prevent type confusion when a ZoneInfo subclass provides a misbehaving cache implementation.

Fixes gh-142781.

@superboy-zjc
pythongh-142781: Fix type confusion in zoneinfo weak cache
bf06241 
Validate the types returned from _weak_cache.get() and
_weak_cache.setdefault() to prevent type confusion when a ZoneInfo
subclass provides a misbehaving cache implementation.
@python-cla-bot
Copy link

python-cla-bot bot commented Dec 18, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Dec 18, 2025
Open
picnixz
picnixz previously requested changes Dec 27, 2025
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented Dec 27, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@superboy-zjc superboy-zjc requested a review from picnixz December 29, 2025 06:21
@superboy-zjc
Copy link
Contributor Author

superboy-zjc commented Dec 29, 2025

Thanks for the review! I have addressed all the comments above. Ready for another look.

picnixz
picnixz reviewed Jan 1, 2026
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should update the branch as we ZoneInfo was modified recently.

@superboy-zjc
Copy link
Contributor Author

superboy-zjc commented Jan 3, 2026

You should update the branch as we ZoneInfo was modified recently.

Thanks for your advice! All comments are resolved. Let me know if anything else is needed!

picnixz
picnixz reviewed Jan 3, 2026
View reviewed changes
@superboy-zjc @picnixz
Update Modules/_zoneinfo.c
110351a 
Co-authored-by: Bénédikt Tran <[email protected]>
@picnixz picnixz dismissed their stale review January 3, 2026 22:02

changes were addressed

@picnixz picnixz self-requested a review January 3, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@picnixz picnixz Awaiting requested review from picnixz

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type confusion in zoneinfo_ZoneInfo_impl via overridden cache setdefault()

2 participants

@superboy-zjc @picnixz