fix(test): Relax assertion in test_ctx_mgr_rollback_if_commit_failed for newer SQLite (GH-143263) #143373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koolvansh07
requested review from
berkerpeksag and
erlend-aasland
as code owners
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
The fix is not just that. We need to understand whether the C code needs to be changed. |
Member
|
Also, please read our policy on AI: https://devguide.python.org/getting-started/generative-ai/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax the assertion in
Lib/test/test_sqlite3/test_dbapi.pyto allow "no error" in addition to "database is locked". This resolves a test failure observed with newer SQLite versions (e.g. 3.47.0+) where the locking behavior is less strict in this specific scenario. Fixes #143263