GH-138245: Perform boolean guards by testing a single bit, rather than a full pointer comparison. #143810
+2,480
−1,027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inter comparison.
Comment on lines
+156
to
+167
| d = id(True) ^ id(False) | ||
| bit = 0 | ||
| for i in range(4, 8): | ||
| if d & (1 << i): | ||
| bit = i | ||
| break | ||
| if bit == 0: | ||
| return "_GUARD_IS_FALSE_POP", "_GUARD_IS_TRUE_POP" | ||
| if id(True) & (1 << bit): | ||
| return f"_GUARD_BIT_IS_UNSET_POP_{bit}", f"_GUARD_BIT_IS_SET_POP_{bit}" | ||
| else: | ||
| return f"_GUARD_BIT_IS_SET_POP_{bit}", f"_GUARD_BIT_IS_UNSET_POP_{bit}" |
Member
There was a problem hiding this comment.
This needs to be dedented one.
| int bit = get_test_bit_for_bools(); | ||
| if (bit) { | ||
| REPLACE_OP(this_instr, | ||
| test_bit_set_in_true(bit) ? |
Member
There was a problem hiding this comment.
Please check this once at the context initialization and set it in the context, then fetch the corresponding op to use from the context.
| int bit = get_test_bit_for_bools(); | ||
| if (bit) { | ||
| REPLACE_OP(this_instr, | ||
| test_bit_set_in_true(bit) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the overhead of performing boolean guards in jitted code.
On Aarch64 reduces the size of the stencil from 5 to 2 instructions.
GUARD_IS_FALSE_POP_r10:_GUARD_BIT_IS_SET_POP_4_r10: