Skip to content

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 19, 2026

It does not support an ASCII string.

Also add more tests.


📚 Documentation preview 📚: https://cpython-previews--144028.org.readthedocs.build/

It does not support an ASCII string.

Also add more tests.
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2026

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@serhiy-storchaka serhiy-storchaka merged commit 25a10b6 into python:main Jan 23, 2026
68 of 70 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the ascii85-decode-ignorechars branch January 23, 2026 18:55
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 23, 2026
…e() (pythonGH-144028)

It does not support an ASCII string.

Also add more tests.
(cherry picked from commit 25a10b60b04ab2fa802409dc6f211cf2ca028a0a)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 23, 2026
…e() (pythonGH-144028)

It does not support an ASCII string.

Also add more tests.
(cherry picked from commit 25a10b6)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 23, 2026

GH-144192 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jan 23, 2026
@bedevere-app
Copy link

bedevere-app bot commented Jan 23, 2026

GH-144193 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 23, 2026
serhiy-storchaka added a commit that referenced this pull request Jan 23, 2026
…de() (GH-144028) (GH-144193)

It does not support an ASCII string.

Also add more tests.
(cherry picked from commit 25a10b6)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jan 23, 2026
…de() (GH-144028) (GH-144192)

It does not support an ASCII string.

Also add more tests.
(cherry picked from commit 25a10b6)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants