gh-145177: Bump Emscripten to 6.0.0#151611
Open
hoodmane wants to merge 1 commit into
Open
Conversation
hoodmane
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland,
freakboy3742 and
itamaro
as code owners
hoodmane
added
skip news
OS-emscripten
needs backport to 3.15
And fix two problems due to changes in Emscripten libc: 1. There was a regression in getentropy that broke it if exactly one byte is requested. Replace it with a wrapped getentropy that replaces a one byte request with a two-byte request and then put the first byte in the original buffer. 2. Emscripten libc now supports umask. We need to initialize the emscripten libc umask to the ambient umask and zero out the ambient umask.
hoodmane
force-pushed
the
emscripten-6.0.0-2
branch
from
3a9f69b to
2ea82b6
Compare
Contributor
|
These changes all makes sense; my only hesitation on merging is establishing exactly the policy is on backports (cf this thread). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And fix two problems due to changes in Emscripten libc: