gh-153395: Accept curses.complexchar in curses.ascii predicates and conversions#153396
Merged
serhiy-storchaka merged 1 commit intoJul 17, 2026
Merged
Conversation
… and conversions The curses.ascii predicates and the ctrl() and unctrl() functions now accept a curses.complexchar, classifying it by its single character. ctrl() now returns a non-ASCII argument unchanged instead of masking it to a control character. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Documentation build overview
|
Member
|
It looks like this broke a few builds, notably Debian root, M1 macOS, and intel macOS. The latter two make me suspect that we're not installing curses on the GHA macOS builders :) |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
curses.asciipredicates and thectrl()andunctrl()functions now accept acurses.complexchar(the character-cell type added in gh-151757), classifying it by its single character. A complexchar that holds combining characters is not a single character and so matches no class.ctrl()now returns a non-ASCII argument unchanged instead of masking it to a control character. There is no control character outside ASCII, and for many keysctrl()on the real terminal is already a no-op (1,',.) or emits irreproducible codes (KEY_BACKSPACE,KEY_RESIZE), so masking a non-ASCII code to a control character was meaningless.ascii(),alt()andismeta()are left unchanged: they remain meaningful only for 8-bit codes, as they already were for most non-ASCII characters.