Skip to content

gh-155143: Fix asyncio.shield leaking tasks via await-graph. - #155144

Merged
kumaraditya303 merged 3 commits into
python:mainfrom
pteromys:main
Aug 15, 2026
Merged

gh-155143: Fix asyncio.shield leaking tasks via await-graph.#155144
kumaraditya303 merged 3 commits into
python:mainfrom
pteromys:main

Conversation

@pteromys

@pteromys pteromys commented Aug 4, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@pteromys
Fix asyncio.shield leaking tasks via await-graph.
1dbd492 
There were two places where `cur_task` could live until `inner` ended:

1. `inner._asyncio_awaited_by`, and
2. as a capture in `_clear_awaited_by_callback` in `inner._callbacks`.
@bedevere-app bedevere-app Bot mentioned this pull request Aug 4, 2026
Closed
kumaraditya303
kumaraditya303 reviewed Aug 4, 2026
View reviewed changes
Comment thread Lib/test/test_asyncio/test_tasks.py Outdated
@pteromys @kumaraditya303
Take kumaraditya303's suggestion on test_tasks.py.
ee2909e 
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
kumaraditya303
kumaraditya303 reviewed Aug 14, 2026
View reviewed changes
Comment thread Lib/test/test_asyncio/test_tasks.py Outdated
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) August 14, 2026 15:34
@kumaraditya303
kumaraditya303 merged commit fbd2e01 into python:main Aug 15, 2026
97 of 99 checks passed
@deadlovelll deadlovelll mentioned this pull request Aug 15, 2026
Closed
@kumaraditya303 kumaraditya303 added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Sep 11, 2026
@miss-islington-app

miss-islington-app Bot commented Sep 11, 2026

Copy link
Copy Markdown

Thanks @pteromys for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Sep 11, 2026

Copy link
Copy Markdown

Thanks @pteromys for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Sep 11, 2026

Copy link
Copy Markdown

GH-157319 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 11, 2026
@bedevere-app

bedevere-app Bot commented Sep 11, 2026

Copy link
Copy Markdown

GH-157320 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Sep 11, 2026
kumaraditya303 pushed a commit that referenced this pull request Sep 11, 2026
@miss-islington @pteromys
[3.14] gh-155143: Fix asyncio.shield() leaking tasks via await-graph (G…
4e0cffb 
…H-155144) (#157319)

gh-155143: Fix asyncio.shield() leaking tasks via await-graph (GH-155144)
(cherry picked from commit fbd2e01)

Co-authored-by: Andrew Geng <pteromys@gmail.com>
hugovk pushed a commit that referenced this pull request Sep 11, 2026
@miss-islington @pteromys
[3.15] gh-155143: Fix asyncio.shield() leaking tasks via await-graph (G…
6a93c91 
…H-155144) (#157320)

Co-authored-by: Andrew Geng <pteromys@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pteromys @kumaraditya303