gh-155496: Use Argument Clinic for more functions of the _io module - #155511
Draft
serhiy-storchaka wants to merge 10 commits into
Draft
serhiy-storchaka wants to merge 10 commits into
serhiy-storchaka wants to merge 10 commits into
Conversation
PyObject_CallMethodNoArgs() and PyObject_CallMethodOneArg() look up the method and call it in one step, without creating a bound method object.
The pickling support and __sizeof__() of BytesIO no longer need separate "lock held" functions.
The getters of _WindowsConsoleIO are left as they are, because Argument Clinic fails for an accessor in a preprocessor conditional block.
# Conflicts: # Modules/_io/clinic/textio.c.h
They are defined in a preprocessor conditional block, which is now supported.
# Conflicts: # Modules/_io/clinic/bufferedio.c.h # Modules/_io/clinic/textio.c.h
The getters which return a boolean or an integer now use the bool, long and Py_ssize_t return converters, and the TextIOWrapper._CHUNK_SIZE setter declares its value as Py_ssize_t. An out of range _CHUNK_SIZE now raises OverflowError instead of ValueError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the methods of
BufferedRWPair, thereadinto()andwrite()methods of_RawIOBase,__enter__(),__exit__()and the_check*()methods of_IOBase, the pickling support and__sizeof__()ofBytesIO, and the private methods ofFileIO.BufferedRWPairnow forwards the arguments to the reader or the writer without packing them into a tuple.The
__getstate__()methods are left as they are, because a single C function is shared by several types.