gh-156460: Await async callable side effects in AsyncMock - #156465
Open
cananoo wants to merge 4 commits into
Open
gh-156460: Await async callable side effects in AsyncMock#156465cananoo wants to merge 4 commits into
cananoo wants to merge 4 commits into
Conversation
picnixz
reviewed
Aug 30, 2026
Comment on lines
+472
to
+473
| class AsyncCallable: | ||
| async def __call__(self, var): |
Member
There was a problem hiding this comment.
Can you add a test where you use an async mock with a sync callable object? i.e. AsyncMock + SyncCallable.
Author
There was a problem hiding this comment.
Added a regression test using a synchronous callable object as AsyncMock.side_effect in commit 7e15b35.
picnixz
reviewed
Aug 30, 2026
Comment on lines
+1
to
+2
| Await async callable objects used as the ``side_effect`` of | ||
| :class:`unittest.mock.AsyncMock`. |
Member
There was a problem hiding this comment.
Suggested change
| Await async callable objects used as the ``side_effect`` of | |
| :class:`unittest.mock.AsyncMock`. | |
| Correctly handle async callable objects used as the ``side_effect`` | |
| of :class:`unittest.mock.AsyncMock`. |
Author
There was a problem hiding this comment.
Applied the suggested NEWS wording in commit 7e15b35.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncMockdid not await callable instances with an asynchronous__call__method when they were used as
side_effect. It returned the coroutine createdby the callable instead, which could result in an unawaited coroutine warning.
This change recognizes an asynchronous
__call__method and awaits thecallable result, while preserving the existing behavior for synchronous
callables and ordinary awaitable return values.
Tests:
./python.exe -m test test_unittest.testmock.testasync -j 0./python.exe -m test test_unittest -j 0./python.exe Tools/patchcheck/patchcheck.pyI used OpenAI Codex to assist with investigating and preparing this change,
and reviewed the resulting code, tests, and documentation before submission.