Fix a bug where runtests.py didn't run non-testcheck .test files individually when asked to #20397
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
…vidually when asked to Due to the way I wrote this feature, generalizing too narrowly from the CONTRIBUTING.md example, you actually could only run testcheck files this way. Luckily, the fix is as simple as not specifying some extra stuff! Since the test file name is in whatever string -k checks against.
A5rocks
approved these changes
Dec 15, 2025
Comment on lines
160
to
162
| + " interpreted as individual test names / substring expressions" | ||
| + " (or, if they end in .test, individual test files)" | ||
| + " (which can end in .test, to specify individual test files)" | ||
| + " and this script will try to run them." |
Collaborator
There was a problem hiding this comment.
Might be easier to just say it's passed onto pytest?
Contributor
Author
There was a problem hiding this comment.
That would be easier, but I wouldn't regard it as explanatory enough. I'd like to briefly explain to the user of runtests.py the important info for them to know, like this; instead of just, say, pointing them to https://docs.pytest.org/en/stable/how-to/usage.html#select-tests (which is correct information about what happens).
Figuring out this specific implication is a service we can provide to the reader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way I wrote this feature, foolishly generalizing too narrowly from the CONTRIBUTING.md example, you actually could only run testcheck files this way. Luckily, the fix is as simple as not specifying some extra stuff! Since the test file name is in whatever string -k checks against.