Fix incorrect type inference for yield from with iterators#20983
Open
dhanusharer wants to merge 2 commits intopython:masterfrom
Open
Fix incorrect type inference for yield from with iterators#20983dhanusharer wants to merge 2 commits intopython:masterfrom
yield from with iterators#20983dhanusharer wants to merge 2 commits intopython:masterfrom
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: bandersnatch (https://github.com/pypa/bandersnatch)
+ src/bandersnatch_storage_plugins/filesystem.py: note: In member "scandir" of class "FilesystemStorage":
+ src/bandersnatch_storage_plugins/filesystem.py:213: error: Incompatible types in "yield from" (actual type "str", expected type "DirEntry[Any]") [misc]
mypy (https://github.com/python/mypy)
+ mypy/report.py:150: error: Incompatible types in "yield from" (actual type "str", expected type "tuple[int, str]") [misc]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17449
Previously, when
yield fromwas used with anIterator[T], mypyfailed to correctly propagate the yielded item type and inferred
Any.This allowed incompatible generator return types to pass type checking.
This change extracts the iterator element type directly in
visit_yield_from_expr, enabling proper type comparison.A regression test has been added.