Skip to content

Fix: suppress Foo[...] suggestion when annotation uses keyword args #21197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vpawela wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: suppress Foo[...] suggestion when annotation uses keyword args #21197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e38a78e
Fix: suppress Foo[...] suggestion when annotation uses keyword args -…
vpawela Apr 9, 2026
344efed
Refine fix: only suppress suggestion when keyword args present
vpawela Apr 9, 2026
2c8e58a
Merge branch 'master' into fix/16506-no-foo-bracket-suggestion
vpawela Apr 9, 2026
e03cf7d
Merge branch 'master' into fix/16506-no-foo-bracket-suggestion
vpawela Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypy/fastparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1957,7 +1957,7 @@ def visit_Call(self, e: Call) -> Type:

if not isinstance(self.parent(), ast3.List):
note = None
if constructor:
if constructor and not e.keywords:
note = "Suggestion: use {0}[...] instead of {0}(...)".format(constructor)
return self.invalid_type(e, note=note)
if not constructor:
Expand Down
9 changes: 9 additions & 0 deletions test-data/unit/check-fastparse.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,15 @@ def f(a: Foo(int)) -> int:
main:7: error: Invalid type comment or annotation
main:7: note: Suggestion: use Foo[...] instead of Foo(...)

[case testFasterParseTypeErrorCustomNoSuggestionForKeywordArgs_no_native_parse]
from typing import TypeVar, Generic
T = TypeVar('T')
class Foo(Generic[T]):
pass
x: Foo(arg=1)
[out]
main:5: error: Invalid type comment or annotation

[case testFastParseMatMul]

from typing import Any
Expand Down
Loading