Support classmethod and staticmethod as converters in attrs plugin#21548
Open
mondeja wants to merge 1 commit into
Open
Support classmethod and staticmethod as converters in attrs plugin#21548mondeja wants to merge 1 commit into
mondeja wants to merge 1 commit into
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for passing staticmethod / classmethod with no decorators to
converterin attrs.Is sound only when the member access is the descriptor's canonical counit (the evaluation of its declared signature for classmethod, the identity for staticmethod) i.e. when there are no other decorators, since there the inferred type coincides by construction with the type checker's.
I'm currently writing
but I would prefer just
as
from_valueis a real converter factory.