-
-
Notifications
You must be signed in to change notification settings - Fork 2k
tensorflow: add a few missing elements
#15265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments/questions below.
| @@ -99,6 +99,9 @@ class Accuracy(MeanMetricWrapper): | |||
| class CategoricalAccuracy(MeanMetricWrapper): | |||
| def __init__(self, name: str | None = "categorical_accuracy", dtype: DTypeLike | None = None) -> None: ... | |||
|
|
|||
| class Mean(MeanMetricWrapper): | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In tensorflow 2.18.1 (which is the latest version typeshed supports), this derives from Reduce:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I've fixed it in bfc1bdb.
43b2a78 to
11c3ce4
Compare
11c3ce4 to
bfc1bdb
Compare
srittau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments.
Co-authored-by: Sebastian Rittau <[email protected]>
Co-authored-by: Sebastian Rittau <[email protected]>
srittau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Thank you! |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
No description provided.