Repository navigation
Make frozendict covariant in its value type - #16669
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16668.
frozendictis immutable, so likeMappingit can be covariant in its value type. The key type stays invariant, since keys are still accepted as parameters (__getitem__,get), which matchesMapping[_KT, _VT_co].The class now uses a new
_VT_cotype variable.get(key, default: _VT_co)carries the same ignore commentsMapping.getuses for a covariant parameter. The__new__overloads keep their own_VT, which is solved per call.Added test cases: a
frozendict[str, int]is accepted wherefrozendict[str, int | None]is expected,get()still narrows as before, and the key type is still invariant.