-
Notifications
You must be signed in to change notification settings - Fork 387
Remove dType Field #3514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove dType Field #3514
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3514
Note: Links to docs will display an error until the docs builds have been completed. ❌ 10 New Failures, 1 Cancelled Job, 2 Unrelated FailuresAs of commit c585724 with merge base 8806b02 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @syedshazli! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Signed the form. |
|
Adding commits, I need to replace mentions of dtype with precision only in modules where dtype is to be deprecated |
|
@pytorchbot label topic: deprecation |
|
Didn't find following labels among repository labels: topic:,deprecation |
|
@pytorchbot label deprecation |
|
Didn't find following labels among repository labels: deprecation |
|
@pytorchbot label "topic: deprecation" |
|
Tests are failing as they still reference dtype. I'm wondering if it's okay for me to edit the tests, or if this deprecation should still expect all tests to pass as is |
In this file, there are multiple comments in the code that say 'remove the dType field as it is not used.' However, the dType field is still instantiated as None in the class.
This PR aims to remove the dType field during initialization of any modules that may have previously referenced it.