Skip to content

Conversation

@syedshazli
Copy link

In this file, there are multiple comments in the code that say 'remove the dType field as it is not used.' However, the dType field is still instantiated as None in the class.

This PR aims to remove the dType field during initialization of any modules that may have previously referenced it.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3514

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures, 1 Cancelled Job, 2 Unrelated Failures

As of commit c585724 with merge base 8806b02 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Dec 18, 2025

Hi @syedshazli!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@syedshazli
Copy link
Author

Signed the form.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 18, 2025
@syedshazli
Copy link
Author

Adding commits, I need to replace mentions of dtype with precision only in modules where dtype is to be deprecated

@syedshazli
Copy link
Author

@pytorchbot label topic: deprecation

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 18, 2025

Didn't find following labels among repository labels: topic:,deprecation

@syedshazli
Copy link
Author

@pytorchbot label deprecation

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 18, 2025

Didn't find following labels among repository labels: deprecation

@syedshazli
Copy link
Author

@pytorchbot label "topic: deprecation"

@pytorch-bot pytorch-bot bot added the topic: deprecation Use this tag if this PR deprecates a feature label Dec 18, 2025
@syedshazli
Copy link
Author

Tests are failing as they still reference dtype. I'm wondering if it's okay for me to edit the tests, or if this deprecation should still expect all tests to pass as is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: deprecation Use this tag if this PR deprecates a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant