-
Notifications
You must be signed in to change notification settings - Fork 387
Remove ::kernels for namespacing #3515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3515
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
8a97f09 to
5753bd1
Compare
|
@pytorchbot --help |
PyTorchBot HelpMergeRevertRebaseLabelDr CIcherry-pick |
|
Didn't find following labels among repository labels: labels,topic:,improvement |
|
Didn't find following labels among repository labels: topic:improvement |
|
Didn't find following labels among repository labels: topic:,imrpovement |
|
@pytorchbot label "topic: improvement" |
This PR addresses a TODO in torchao\csrc\cpu\torch_free_kernels\fallback\matmul\fp32_a_channelwise_8bit_b_fp32_c.h which says "TODO: Remove all ::kernels. No need for extra namespace."
I presume this meant remove all namespaces within the codebase that reference ::kernels, which is why this commit is so large. If this is not the case and was only meant for the .h file, I can change the commit to reflect this.