Skip to content

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Dec 18, 2025

Summary:

  1. Pass segment_alignment from ExecutorchBackendConfig to flat tensor serializer
  2. Set segment_alignment=128 as default to match ExecutorchBackendConfig
  3. Remove tensor_alignment from the config (do not have multiple tensors per segment)
  4. Additional tests for varying segment alignment.

Differential Revision: D89422691

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16317

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit e334922 with merge base c61b2ed (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 18, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 18, 2025

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89422691.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Dec 18, 2025
Summary:

1. Pass segment_alignment from ExecutorchBackendConfig to flat tensor serializer
2. Set segment_alignment=128 as default to match ExecutorchBackendConfig
3. Remove tensor_alignment from the config (do not have multiple tensors per segment)
4. Additional tests for varying segment alignment.

Differential Revision: D89422691
nitish2112 and others added 2 commits December 18, 2025 11:27
Differential Revision: D89237435
Summary:

1. Pass segment_alignment from ExecutorchBackendConfig to flat tensor serializer
2. Set segment_alignment=128 as default to match ExecutorchBackendConfig
3. Remove tensor_alignment from the config (do not have multiple tensors per segment)
4. Additional tests for varying segment alignment.

Differential Revision: D89422691
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants