-
Notifications
You must be signed in to change notification settings - Fork 767
add support for Qualcomm QCM6490 #16331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16331
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 1 Unrelated FailureAs of commit f1634d9 with merge base 0fb422f ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @9rum! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@pytorchbot label "release notes: backends" |
|
Didn't find following labels among repository labels: release notes: backends |
|
@pytorchbot label "release notes: qualcomm" |
|
Hi @shewu-quic @chenweng-quic @winskuo-quic @DannyYuyang-quic @haowhsu-quic if you take a look at this PR fixing #7356 |
source: fix typo
cccclai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing! I wonder how you run llama on QCM6490? It seems like v68 and doesn't support block wise quantization, which means the accuracy won't be ideal
|
@cccclai Thank you for your kind reply. BTW, I see there is an enum value conflict: |
Summary
This PR adds support for Qualcomm QCM6490, which has been discussed in issue #7356.
Fixes
Fixes #7356.
Test plan
The changes in this PR have been tested with the official Llama example.