Use std::isfinite() instead of isfinite() in portable ops. #16340
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This make it possible to build with a simpler libc and saves some flash space. When moving from NEWLIB_LIBC in ZephyrOS to the default one we saved almost 60 Kb in the flash memory (with a simple add model, larger models/code might save less as more libc stuff are probably used). Signed-off-by: Zingo Andersen <[email protected]> Change-Id: I7e9bee8646a503d109ecc6b6c72365fd8e78becf
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16340
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit b3e30cd with merge base f3fd55c ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
zingo
added
ciflow/trunk
partner: arm
| } | ||
| } else { | ||
| auto allowed_error = atol + fabs(rtol * b[i]); | ||
| auto actual_error = fabs(a[i] - b[i]); |
Contributor
There was a problem hiding this comment.
std::fabs for consistency?
mergennachin
approved these changes
Dec 23, 2025
Contributor
mergennachin
left a comment
mergennachin
left a comment
There was a problem hiding this comment.
Nice, thank you for figuring this out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This make it possible to build with a simpler libc and saves some flash space. When moving from NEWLIB_LIBC in ZephyrOS to the default one we saved almost 60 Kb in the flash memory (with a simple add model, larger models/code might save less as more libc stuff are probably used).
Test plan
Test by building ExecuTorch from ZephyrOS with and without NEWLIB_LIBC by hand.
cc @freddan80 @per @oscarandersson8218 @digantdesai