Add nxp backend profiling support#19225
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19225
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ 7 Pending, 1 Unrelated FailureAs of commit 6031ad9 with merge base 2b1ccd4 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Please fix the linting errors and look at our comments. For information how to run the lintrunner see https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md .
In short:
$ lintrunner init
$ lintrunner --merge-base-with <reference to last commit outside of your contribution>
|
Internal CI build: https://bamboo3.sw.nxp.com/browse/MLTECE-EXIGH146 |
7a2d30c to
f7c7896
Compare
|
9d924bb to
9a8a99b
Compare
9a8a99b to
d45d32c
Compare
| ) | ||
| # Two graphs are expected in the input log: original and converted. | ||
| EXPECTED_GRAPHS = 2 | ||
| # List of single-input nodes that shouldn't be mapped on the same TFLite node. |
There was a problem hiding this comment.
I don't really understand which nodes is this list supposed to contain. What does the comment mean? Are there any single input nodes which shouldn't be in this list?
Also, is this list complete? Or will we ever need to add operators to it?
There was a problem hiding this comment.
I created this list from the output of ./neutron-converter --show-kernel-kinds --target imxrt700. I selected all single-input kernels that can be executed in parallel with the same input.
As I understand, no additional kernels are expected for Neutron-C. If that is correct, this should be a complete list for Neutron-C.
The comment means that if two or more kernels from the list are mapped to the same TFLite node, this is incorrect. In such cases, we need to further analyze and filter the results to keep only one Neutron node that corresponds to the TFLite node name.
ec062cc to
54cf6d4
Compare
54cf6d4 to
804c3e2
Compare
|
@robert-kalmar, can you please rerun the pending checks? |
|
Again, a conflict? Sorry, I didn’t notice that. It was perfectly fine yesterday :( |
Signed-off-by: Irina Korchakova <irina.trukhina@nxp.com>
804c3e2 to
b14a37d
Compare
Summary
Add profiling support for the NXP backend.
Test plan
All CI tests passed including new test for the profiling feature.
cc @robert-kalmar @JakeStevens @digantdesai