Skip to content

Arm backend: Add bfloat16 support to VGF backend.#20299

Open
Erik-Lundell wants to merge 1 commit into
pytorch:mainfrom
Erik-Lundell:upstream-bf16-vgf
Open

Arm backend: Add bfloat16 support to VGF backend.#20299
Erik-Lundell wants to merge 1 commit into
pytorch:mainfrom
Erik-Lundell:upstream-bf16-vgf

Conversation

@Erik-Lundell

@Erik-Lundell Erik-Lundell commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator
  • Add bf16 extension to Vgf testing pipline
  • Handle bf16 in VGFSetup.sh
  • Needs bumping of Vulkan SDK to 1.4.350.0 to include VK_FORMAT_R16_SFLOAT_FPENCODING_BFLOAT16_ARM

Initially tested with a single operator test of matmul.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

@pytorch-bot

pytorch-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20299

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures, 5 Unrelated Failures

As of commit cf8b909 with merge base 2e328aa (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 16, 2026
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 16, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jun 16, 2026
@Erik-Lundell Erik-Lundell added help wanted Extra attention is needed release notes: arm Changes to the ARM backend delegate ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. and removed ciflow/trunk module: arm Issues related to arm backend labels Jun 16, 2026
@github-actions github-actions Bot added the module: arm Issues related to arm backend label Jun 17, 2026

@volkkov volkkov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement overall. One edge case: empty string vs null aren't treated the same downstream — might need a normalization step.

@Erik-Lundell

Copy link
Copy Markdown
Collaborator Author

Good improvement overall. One edge case: empty string vs null aren't treated the same downstream — might need a normalization step.

Thanks for the comment volkkov, could you please be a bit more specific? I.e. which string

- Add bf16 extension to default VgfCompileSpec
- Handle bf16 in VGFSetup.sh
- Needs bumping of Vulkan SDK to 1.4.350.0 to include
VK_FORMAT_R16_SFLOAT_FPENCODING_BFLOAT16_ARM

Initially tested with a single operator test of matmul.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: I74b0c15b5a4f9194c437e8e69d2349e9c282878b

@digantdesai digantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will let @SS-JIA stamp it due to the submodule update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. help wanted Extra attention is needed module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants