Revert "Arm backend: Add a repro command when VGF model-converter fails"#20477
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20477
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ 17 Pending, 5 Unrelated FailuresAs of commit 82bd3a0 with merge base 1621fa2 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
zingo
added
partner: arm
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Reverts the prior Arm VGF backend change that added a shell-safe “repro command” and failure-artifact preservation when model-converter fails, returning the backend and its tests to the earlier behavior.
Changes:
- Removes helper utilities for formatting repro commands and copying failing TOSA inputs on converter errors.
- Simplifies
vgf_compileerror handling to raise a basicRuntimeErrorincluding stdout/stderr. - Deletes the unit tests that covered the removed repro/artifact behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
backends/arm/vgf/backend.py |
Removes repro/artifact helpers and reverts converter failure handling to a simpler error message. |
backends/arm/test/misc/test_vgf_backend.py |
Removes tests that validated repro-command formatting and failure-artifact copying. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| conversion_command_str = " ".join(conversion_command) | ||
| raise RuntimeError( | ||
| "Vgf compiler failed.\n" | ||
| f"Repro command:\n {_format_repro_command(repro_command)}\n" | ||
| f"Stderr:\n{process_error.stderr.decode()}\n" | ||
| f"Stdout:\n{process_error.stdout.decode()}" | ||
| f"Vgf compiler ('{conversion_command_str}') failed with error:\n \ | ||
| {process_error.stderr.decode()}\n \ | ||
| Stdout:\n{process_error.stdout.decode()}" |
|
Fails are unrelated |
Reverts #20443
Got some CI fails will try again later
cc @digantdesai @freddan80 @per @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani