Skip to content

Require strict profitability before advancing quantization above slices - #22807

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
DrJessop:export-D119550687
Sep 15, 2026
Merged

meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
DrJessop:export-D119550687

Conversation

@DrJessop

@DrJessop DrJessop commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Summary: Require a strict profitability win before advancing quantization above slice or select operations. When the float slice outputs and the quantized input have equal estimated memory cost, keep the slice before quantization to avoid quantizing elements that will be discarded. Add coverage for the half-sized-slice boundary.

Differential Revision: D119550687

@pytorch-bot

pytorch-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22807

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit fa0087a with merge base 13ec99a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 14, 2026
@meta-codesync

meta-codesync Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119550687.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary: Require a strict profitability win before advancing quantization above slice or select operations. When the float slice outputs and the quantized input have equal estimated memory cost, keep the slice before quantization to avoid quantizing elements that will be discarded. Add coverage for the half-sized-slice boundary.

Differential Revision: D119550687
@meta-codesync meta-codesync Bot changed the title Update propagate slice to still move the slice for equal cost calculations Require strict profitability before advancing quantization above slices Sep 15, 2026
DrJessop added a commit to DrJessop/executorch that referenced this pull request Sep 15, 2026
…es (pytorch#22807)

Summary:

Require a strict profitability win before advancing quantization above slice or select operations. When the float slice outputs and the quantized input have equal estimated memory cost, keep the slice before quantization to avoid quantizing elements that will be discarded. Add coverage for the half-sized-slice boundary.

Differential Revision: D119550687
@meta-codesync
meta-codesync Bot merged commit f5e1369 into pytorch:main Sep 15, 2026
205 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants