Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22811
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0e09115 with merge base 026ca3f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120017028. |
This PR needs a
|
meta-codesync
Bot
changed the title
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Sep 14, 2026
Summary: Host replay sanitizers exposed undefined behavior when non-finite quantization results were converted to integers before clamping. Define deterministic behavior: NaN maps to the clamped zero point, positive infinity to quant_max, and negative infinity to quant_min. Clamp before integer conversion and keep scalar and ARM exceptional-value handling consistent, with regression coverage for non-finite inputs, finite overflow, zero-point clamping, and per-channel quantization. Adapted from the repair proposed in D119101166. Edits were made in fbcode; the repository commit hook mirrored them into xplat, and the mirrored changes are retained. Authored with assistance from Devmate. Differential Revision: D120017028
metascroy
force-pushed
the
export-D120017028
branch
from
September 14, 2026 19:25
8c8d8af to
a5a073c
Compare
rascani
approved these changes
Sep 14, 2026
rascani
left a comment
rascani
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Sep 14, 2026
Summary: Host replay sanitizers exposed undefined behavior when non-finite quantization results were converted to integers before clamping. Define deterministic behavior: NaN maps to the clamped zero point, positive infinity to quant_max, and negative infinity to quant_min. Clamp before integer conversion and keep scalar and ARM exceptional-value handling consistent, with regression coverage for non-finite inputs, finite overflow, zero-point clamping, and per-channel quantization. Adapted from the repair proposed in D119101166. Edits were made in fbcode; the repository commit hook mirrored them into xplat, and the mirrored changes are retained. Authored with assistance from Devmate. Reviewed By: rascani Differential Revision: D120017028
metascroy
force-pushed
the
export-D120017028
branch
from
September 14, 2026 20:58
a5a073c to
f845bc6
Compare
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Sep 14, 2026
Summary: Host replay sanitizers exposed undefined behavior when non-finite quantization results were converted to integers before clamping. Define deterministic behavior: NaN maps to the clamped zero point, positive infinity to quant_max, and negative infinity to quant_min. Clamp before integer conversion and keep scalar and ARM exceptional-value handling consistent, with regression coverage for non-finite inputs, finite overflow, zero-point clamping, and per-channel quantization. Adapted from the repair proposed in D119101166. Edits were made in fbcode; the repository commit hook mirrored them into xplat, and the mirrored changes are retained. Authored with assistance from Devmate. Reviewed By: rascani Differential Revision: D120017028
metascroy
force-pushed
the
export-D120017028
branch
from
September 14, 2026 23:55
f845bc6 to
f62e5d8
Compare
Summary: Host replay sanitizers exposed undefined behavior when non-finite quantization results were converted to integers before clamping. Define deterministic behavior: NaN maps to the clamped zero point, positive infinity to quant_max, and negative infinity to quant_min. Clamp before integer conversion and keep scalar and ARM exceptional-value handling consistent, with regression coverage for non-finite inputs, finite overflow, zero-point clamping, and per-channel quantization. Adapted from the repair proposed in D119101166. Edits were made in fbcode; the repository commit hook mirrored them into xplat, and the mirrored changes are retained. Authored with assistance from Devmate. Reviewed By: rascani Differential Revision: D120017028
metascroy
force-pushed
the
export-D120017028
branch
from
September 15, 2026 16:47
f62e5d8 to
0e09115
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Host replay sanitizers exposed undefined behavior when non-finite quantization results were converted to integers before clamping. Define deterministic behavior: NaN maps to the clamped zero point, positive infinity to quant_max, and negative infinity to quant_min. Clamp before integer conversion and keep scalar and ARM exceptional-value handling consistent, with regression coverage for non-finite inputs, finite overflow, zero-point clamping, and per-channel quantization.
Adapted from the repair proposed in D119101166. Edits were made in fbcode; the repository commit hook mirrored them into xplat, and the mirrored changes are retained. Authored with assistance from Devmate.
Reviewed By: rascani
Differential Revision: D120017028