Arm backend: Remove legacy quantizer - #22838
Open
Sebastian-Larsson wants to merge 3 commits into
Open
Sebastian-Larsson wants to merge 3 commits into
Sebastian-Larsson wants to merge 3 commits into
Conversation
Remove _TOSAQuantizerV1 and its supporting helpers, deprecated in ExecuTorch 1.4. Use the composable quantizer for all Arm targets. Retain use_composable_quantizer for API compatibility and reject False with a removal message. Update the tests and documentation for the composable implementation. Change-Id: I1233ac75ae7371e55757cb2676e2d538225fac51 Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
Move quantization-spec helpers into quantization_config, operator sets into quantizer_support, and scalar checks into the Cortex-M pattern matcher. Delete quantization_annotator and its build dependencies. Change-Id: I5b2db2955f8630ab6c53ab29cca19e44ab8e0220 Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
Sebastian-Larsson
requested review from
digantdesai,
mergennachin and
rascani
as code owners
September 15, 2026 14:38
Sebastian-Larsson
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22838
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 Unrelated FailuresAs of commit 1e361be with merge base 026ca3f ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
We still have some internal usage of the legacy quantizer, I'll look into the what it will take to finish that migration. |
rascani
reviewed
Sep 15, 2026
| "This API is experimental and may change without notice. " | ||
| "It is only available when use_composable_quantizer=True." | ||
| ) | ||
| @experimental("This API is experimental and may change without notice.") |
Contributor
There was a problem hiding this comment.
If we're removing the legacy quantizer, can we remove the experimental tag on the new one? Is there any remaining work to mark this as stable?
Collaborator
There was a problem hiding this comment.
I agree, I have no remaining work from my side and I have not seen much issues with it recently.
Collaborator
Author
There was a problem hiding this comment.
Thanks @AdrianLundell
@rascani I will wait for furher feedback from you in case I need to change anything else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove legacy quantizer and remove quantization_annotator.py file. Helper functions inside it that remained are moved closer to their usage (same file).
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @robell @rascani