Repository navigation
docs(runner): mobile actions in runner actions sequences (AGE-5384) - #1649
Closed
Erzhan Torokulov (erzhtor) wants to merge 1 commit into
Closed
Erzhan Torokulov (erzhtor) wants to merge 1 commit into
Erzhan Torokulov (erzhtor) wants to merge 1 commit into
Conversation
runner.md still said sequences take only browser actions, which stopped being true in 1.39.0, and that click and drag tap and swipe on mobile, which stops being true once the platform refuses them there.
4 tasks done
Contributor
Author
|
Folded into #1652, which moves the runner guide into the CLI's help and generates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to AGE-5427 and AGE-5384. Follows #1642; pairs with qawolf/platform#34510.
Overview of Changes
skills/qawolf-cli/references/runner.mdhad fallen out of date in two places. Itsrunner actionssection said sequences take only browser actions "(nottap,swipeorfill)", which stopped being true in 1.39.0 (#1642). Its mobile section saidclickanddragstill tap and swipe on mobile, which stops being true once qawolf/platform#34510 refuses them there.The
runner actionssection now says sequences take the same actions asact, names the per-step refusal reasons, and adds a mobile example. The mobile section now says to sendtapandswipe, neverclickordrag, which is correct both before and after #34510 deploys, so this can ship now. Docs only, no code changes.Testing
generateproduces no drift. Tests pass except 3 keychain tests that also fail onmainon this machine.Checklist