Tech/bsp/soc infra pd-mapper #618
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_req_ei It looks element length declared in servreg_loc_pfr_req_ei for reason not matching servreg_loc_pfr_req's reason field due which we could observe decoding error on PD crash. qmi_decode_string_elem: String len 81 >= Max Len 65 Fix this by matching with servreg_loc_pfr_req's reason field. Cc: [email protected] Fixes: 1ebcde0 ("soc: qcom: add pd-mapper implementation") Reviewed-by: Dmitry Baryshkov <[email protected]> Co-developed-by: Gokul Krishnakumar <[email protected]> Signed-off-by: Gokul Krishnakumar <[email protected]> Signed-off-by: Mukesh Ojha <[email protected]> Signed-off-by: Xin Liu <[email protected]> Link: https://lore.kernel.org/all/[email protected]/
Few error paths in the qmi_interface module log a failure message but do not include the actual error code. Include the error value in the log so debugging failures becomes easier. Reviewed-by: Dmitry Baryshkov <[email protected]> Signed-off-by: Mukesh Ojha <[email protected]> Signed-off-by: Xin Liu <[email protected]> Link: https://lore.kernel.org/all/[email protected]/
LXQUALCOMM
force-pushed
the
tech/bsp/soc-infra
branch
from
cdd57c2 to
80bba1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FROMLIST: soc: qcom: qmi: Print error codes in failure paths
Few error paths in the qmi_interface module log a failure message but
do not include the actual error code. Include the error value in the log
so debugging failures becomes easier.
Signed-off-by: Mukesh Ojha [email protected]
Signed-off-by: Xin Liu [email protected]
FROMLIST: soc: qcom: pd-mapper: Fix element length in servreg_loc_pfr_req_ei
It looks element length declared in servreg_loc_pfr_req_ei for reason
not matching servreg_loc_pfr_req's reason field due which we could
observe decoding error on PD crash.
qmi_decode_string_elem: String len 81 >= Max Len 65
Fix this by matching with servreg_loc_pfr_req's reason field.
Fixes: 1ebcde0 ("soc: qcom: add pd-mapper implementation")
Signed-off-by: Mukesh Ojha [email protected]
Signed-off-by: Xin Liu [email protected]