Fix incorrect refactor of provideStatementRange#865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #825 @juliasilge noticed that statement execution was broken in Positron source editor for python code cells. I tracked down the issue to a refactor in my previous PR #857.
In #857 I attempted to refactor
provideStatementRange. The refactor consisted of inlining a function into another. I made a mistake while inlining, leaving some important code behind. @juliasilge noticed that the change was breaking (see #857 (comment)), and I attempted to address the mistake. I fixed the mistake, adding back in the missing code, but in the process I accidentally introduced another mistake: usingpositioninstead ofadjustedPosition(vdoc.language, position).I have tested this PR and it fixes statement range execution in Positron source editor for python code cells.
Next time I do a refactor, I need to find ways to be more systematic about it. It also motivates me to set up some infrastructure for source-mode tests for statement and cell execution. For now, I will put up a small PR to fix the problem.