core: load configs from the vfs mirror to enable the qml disk cache - #1049
Open
bbedward wants to merge 2 commits into
Open
core: load configs from the vfs mirror to enable the qml disk cache#1049bbedward wants to merge 2 commits into
bbedward wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in the codebase and #735, the QML disk cache doesnt work with
qs:URLs.This makes
vfs/<id>/qsthe import root and mirrors the full config there. Normal dirs are symlinked directly; dirs with generated files likeqmldir,//@ if, orqml.jsonare mirrored with symlinks plus the generated files. Generated files are only rewritten when their contents change so cache mtimes stay valid.The URL interceptor also canonicalizes config QML/JS/qmldir paths into the mirror so the same document cant be loaded under both
qs:andfile:URLs.If the VFS cant be created it falls back to
qs:like before.On DMS this drops warm launch to "Configuration Loaded" from 1.28s to 0.77s and RSS by ~40MB.
Verify with
QT_LOGGING_RULES=qt.qml.diskcache=true; the second run should be silent.