Round share graph values to 14 #182
Open
+43
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louispt1
force-pushed
the
round-graph-values
branch
from
35fc857 to
cee09e8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #182 +/- ##
==========================================
- Coverage 92.75% 92.72% -0.04%
==========================================
Files 92 92
Lines 2650 2665 +15
==========================================
+ Hits 2458 2471 +13
- Misses 192 194 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Ok @kndehaan I have now updated Atlas and Transformer to round all graph values to 14 decimal places. I am tagging @mabijkerk and @noracato on this PR to initiate a discussion on whether 14 decimal places is an acceptable choice for rounding as of now? It would be good to be aligned on this decision as a team (although of course we can always change our mind). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR rounds all share graph values to 14 decimal places.
This change is to avoid floating point issues, and allow values to be easily handled with excel.
The changes go with this PR for Transformer.
@kndehaan perhaps you could functionally review these changes in the context of exporting these datasets? I tested PV27.
If you're happy with how it works, let's also get a code review from one of the developers.
Before merging:
Related Issues
Closes this ETSource Issue