Skip to content

Conversation

@kaskranenburgQ
Copy link
Contributor

@kaskranenburgQ kaskranenburgQ commented Dec 18, 2025

Description

Share Queries (10 new files)

  • Added biogenic share calculations for agriculture, buildings, households, and industry sectors (energetic use)
  • Added biogenic share calculation for industry non-energetic use
  • Added complementary non-biogenic share queries (calculated as 1 - biogenic share) for all sectors

The biogenic share queries calculate the proportion of biodiesel, bio-kerosene, and bio-oil input conversions in crude oil final demand nodes.

Final Demand Queries (11 new files)

  • Added biogenic oil final demand queries for agriculture, buildings, households, and industry (energetic and non-energetic)
  • Added non-biogenic oil final demand queries for the same sectors
  • Added industry non-energetic oil and derivatives final demand query

Industry-Specific Implementation: The industry sector queries use a different approach than other sectors:
Other sectors multiply total oil demand by the biogenic/non-biogenic share

  • Industry queries separate naphtha (which is modeled independently as naphtha vs bionaphtha) from other oil products:
    • For biogenic: crude_oil demand × biogenic_share + full bionaphtha demand
    • For non-biogenic: crude_oil demand × non-biogenic_share + full naphtha demand

Type of change

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist

  • I have tested these changes
  • I have updated documentation as needed
  • I have tagged the relevant people for review

Related Issues

Closes #3377

@kaskranenburgQ kaskranenburgQ marked this pull request as ready for review December 18, 2025 13:59
Copy link
Contributor

@kndehaan kndehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good, logical query structure! See my one specific comment regarding querying bionaphtha.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think bionaphta shouldn't be in here. The problem for the client is when using the standard final demand queries, the query final_demand_of_oil_and_derivatives_in_industry_energetic implicitly has a biogenic share due to the crude oil final demand node.

So what is the biogenic share of this query? That only consists of biodiesel, bio_kerosene and bio_oil. This comment also applies to the non-energetic query. Final demand of bionaphta is already queried with final_demand_of_biomass_products_in_industry_energetic.

Perhaps we should also rename this query then to make this more clear, e.g. final_demand_of_biogenic_in_oil_and_derivatives_in_industry_energetic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add queries that separate final demand of bio-oil and oil.

3 participants