-
Notifications
You must be signed in to change notification settings - Fork 9
Offshore wind queries #3386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Offshore wind queries #3386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Minor suggestions:
- Just for the full picture (and the client can then decide which to use or not, I don't remember exactly what they want to be able to query precisely), do we also want to add two separate queries for:
- total electricity production from hybrid offshore wind? This would then represent the total electricity production from the offshore wind turbines in the hybrid configuration. I think this means that it should include electricity going to hydrogen production, and exclude electricity going to the curtailment node.
- electricity production from offshore wind for dedicated hydrogen production
- I would change the name
electricity_produced_to_land_from_hybrid_offshore_windtoelectricity_produced_from_hybrid_offshore_wind_to_land
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Query input_of_electricity for energy_hydrogen_hybrid_electrolysis_wind_electricity also includes electricity received from the onshore electricity grid. I think we should only query electricity produced from by the offshore wind turbines going to hydrogen production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point! I have modified the query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're adding a query for curtailed electricity from dedicated hydrogen production from offshore wind, shouldn't we also add a curtailment query for hybrid offshore wind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would make sense. The new set of queries should ideally sum to the result of the existing query electricity_wind_offshore_output_of_electricity which represents total offshore wind production (used in the electricity mekko). I think the only query missing for this is the curtailment in hybrid offshore. But could you verify whether this is true?
… offshore wind production query
Description
This PR adds offshore wind queries requested in #3375
Type of change
Checklist
Related Issues
Closes #3375