Persist cleared shortcuts instead of restoring defaults#1144
Merged
qvacua merged 1 commit intoqvacua:masterfrom Dec 22, 2025
Merged
Persist cleared shortcuts instead of restoring defaults#1144qvacua merged 1 commit intoqvacua:masterfrom
qvacua merged 1 commit intoqvacua:masterfrom
Conversation
Custom keyboard shortcuts cleared in Preferences would frustratingly revert to defaults after a restart. This happened because clearing a shortcut removed its UserDefaults key, causing the app to misinterpret it as "never set" on the next launch. This fix ensures that clearing a shortcut stores an explicit "empty" value. This preserves the user's intent to disable the shortcut and prevents the default value from being restored. Co-authored-by: Gemini <gemini@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom keyboard shortcuts cleared in Preferences would frustratingly revert to defaults after a restart. This happened because clearing a shortcut removed its UserDefaults key, causing the app to misinterpret it as "never set" on the next launch.
This fix ensures that clearing a shortcut stores an explicit "empty" value. This preserves the user's intent to disable the shortcut and prevents the default value from being restored.
Fixed by Gemini CLI.
This should close #537, #951, and #1050.