Fix issue where ctrlf--finalize doesn't push starting point mark when auto-recenter enabled#133
Merged
raxod502 merged 2 commits intoradian-software:mainfrom Dec 12, 2025
Conversation
Member
|
I dunno if there was a good reason I wrote it like this originally. I know there was some weird stuff many years ago about recentering the window properly, and I tried changing things to fix it, but then it broken in other cases... but my knowledge about that has long since dissipated. If this change fixes it for you, and I agree it looks correct, then I say we go for it and see if anyone else reports issues. Mind adding a changelog entry? |
Contributor
Author
|
Hmm, I at least can't think of any scenario where this fails, and everything works fine in my testing. I added a changelog entry. |
raxod502
approved these changes
Dec 12, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I found and fixed what I believe to be a bug, where
ctrlf--finalizedoesn'tpush-markthectrlf--starting-pointwhenctrlf-auto-recenteris enabled.I have always been a user of
ctrlf-auto-recenter, and I was having trouble getting back to where I started my ctrlf searches from. I thought it would be a nice feature to save the mark of the starting point. Then I looked in the code and saw this feature already existed, but the logic disabled it whenctrlf-auto-recenterwas enabled. This PR fixes this logic.Let me know your thoughts, and thanks for the work done on this useful package!