Skip to content

Fix issue where ctrlf--finalize doesn't push starting point mark when auto-recenter enabled#133

Merged
raxod502 merged 2 commits intoradian-software:mainfrom
NicholasBHubbard:push-mark-when-auto-recenter
Dec 12, 2025
Merged

Fix issue where ctrlf--finalize doesn't push starting point mark when auto-recenter enabled#133
raxod502 merged 2 commits intoradian-software:mainfrom
NicholasBHubbard:push-mark-when-auto-recenter

Conversation

@NicholasBHubbard
Copy link
Contributor

@NicholasBHubbard NicholasBHubbard commented Dec 10, 2025

Hello! I found and fixed what I believe to be a bug, where ctrlf--finalize doesn't push-mark the ctrlf--starting-point when ctrlf-auto-recenter is enabled.

I have always been a user of ctrlf-auto-recenter, and I was having trouble getting back to where I started my ctrlf searches from. I thought it would be a nice feature to save the mark of the starting point. Then I looked in the code and saw this feature already existed, but the logic disabled it when ctrlf-auto-recenter was enabled. This PR fixes this logic.

Let me know your thoughts, and thanks for the work done on this useful package!

@raxod502
Copy link
Member

I dunno if there was a good reason I wrote it like this originally. I know there was some weird stuff many years ago about recentering the window properly, and I tried changing things to fix it, but then it broken in other cases... but my knowledge about that has long since dissipated.

If this change fixes it for you, and I agree it looks correct, then I say we go for it and see if anyone else reports issues.

Mind adding a changelog entry?

@NicholasBHubbard
Copy link
Contributor Author

Hmm, I at least can't think of any scenario where this fails, and everything works fine in my testing.

I added a changelog entry.

@raxod502
Copy link
Member

Thanks!

@raxod502 raxod502 merged commit 3e1d4d7 into radian-software:main Dec 12, 2025
4 checks passed
@NicholasBHubbard NicholasBHubbard deleted the push-mark-when-auto-recenter branch December 16, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants