Fixed OneTimePasswordField's dispatch function. #3770
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described by issue #3709, starting with React 19.2, the
OneTimePasswordFieldcomponent no longer functions properly.The issue being React's
useEffectEventhook being used to define thedispatchfunction instead of using React'suseCallbackhook which allows dependencies to be supplied. Particularly thecollectionstate value wouldn't update properly causing the value inside thedispatchfunction to be out of sync with the latest state.React 19.1:
React 19.2:
Caveats of the
useEffectEventhook according the documentation of React:So I have updated the
dispatchto make use of React'suseCallbackhook instead restoring the functionality ofOneTimePasswordField.