Skip to content

Memoize Runnable#mode to stop allocating a String + StringInquirer pe… #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s01ipsist wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Memoize Runnable#mode to stop allocating a String + StringInquirer pe… #744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/solid_queue/processes/runnable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ module SolidQueue::Processes
module Runnable
include Supervised

attr_writer :mode
def mode=(value)
@mode = (value || DEFAULT_MODE).to_s.inquiry
end

def start
run_in_mode do
Expand Down Expand Up @@ -33,7 +35,7 @@ def alive?
DEFAULT_MODE = :async

def mode
(@mode || DEFAULT_MODE).to_s.inquiry
@mode ||= DEFAULT_MODE.to_s.inquiry
end

def run_in_mode(&block)
Expand Down
Loading