Skip to content

test token-revert bubble-up paths in LibFlow transfers#450

Open
thedavidmeister wants to merge 1 commit intomainfrom
2026-05-05-issue-331-token-revert-bubble-tests
Open

test token-revert bubble-up paths in LibFlow transfers#450
thedavidmeister wants to merge 1 commit intomainfrom
2026-05-05-issue-331-token-revert-bubble-tests

Conversation

@thedavidmeister
Copy link
Copy Markdown
Contributor

Summary

Three new fuzz tests, one per token standard, pinning that an underlying token revert propagates out of flow() rather than being caught and swallowed by SafeERC20 or the bare ERC721/ERC1155 interface calls in LibFlow.

  • testFlowERC20TokenRevertBubblesUpTOKEN_A.transferFrom reverts.
  • testFlowERC721TokenRevertBubblesUpTOKEN_B.safeTransferFrom reverts.
  • testFlowERC1155TokenRevertBubblesUpTOKEN_C.safeTransferFrom reverts.

Closes #331.

Test plan

  • all 3 tests, 100 fuzz runs each

🤖 Generated with Claude Code

Three new fuzz tests, one per token standard:

- testFlowERC20TokenRevertBubblesUp — TOKEN_A.transferFrom reverts
- testFlowERC721TokenRevertBubblesUp — TOKEN_B.safeTransferFrom reverts
- testFlowERC1155TokenRevertBubblesUp — TOKEN_C.safeTransferFrom reverts

Each pins that the underlying token revert propagates out of flow()
rather than being caught and swallowed by SafeERC20 / the interface
calls in LibFlow.

Closes #331.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

Warning

Rate limit exceeded

@thedavidmeister has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 34 minutes and 14 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 41337219-3303-42c7-8e67-bf022b56f57b

📥 Commits

Reviewing files that changed from the base of the PR and between ceaea3c and 79fbf70.

📒 Files selected for processing (1)
  • test/src/concrete/Flow.transfer.t.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-05-issue-331-token-revert-bubble-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[A23-4] [MEDIUM] LibFlow transfers: token-revert bubble-up paths uncovered

1 participant