test token-revert bubble-up paths in LibFlow transfers#450
test token-revert bubble-up paths in LibFlow transfers#450thedavidmeister wants to merge 1 commit intomainfrom
Conversation
Three new fuzz tests, one per token standard: - testFlowERC20TokenRevertBubblesUp — TOKEN_A.transferFrom reverts - testFlowERC721TokenRevertBubblesUp — TOKEN_B.safeTransferFrom reverts - testFlowERC1155TokenRevertBubblesUp — TOKEN_C.safeTransferFrom reverts Each pins that the underlying token revert propagates out of flow() rather than being caught and swallowed by SafeERC20 / the interface calls in LibFlow. Closes #331. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Three new fuzz tests, one per token standard, pinning that an underlying token revert propagates out of
flow()rather than being caught and swallowed bySafeERC20or the bare ERC721/ERC1155 interface calls inLibFlow.testFlowERC20TokenRevertBubblesUp—TOKEN_A.transferFromreverts.testFlowERC721TokenRevertBubblesUp—TOKEN_B.safeTransferFromreverts.testFlowERC1155TokenRevertBubblesUp—TOKEN_C.safeTransferFromreverts.Closes #331.
Test plan
🤖 Generated with Claude Code