Skip to content

feat: update rain.metadata submodule for RaindexSignedContextOracleV1#427

Merged
hardyjosh merged 2 commits intomainfrom
feat/signed-context-oracle-meta-submodule
Mar 7, 2026
Merged

feat: update rain.metadata submodule for RaindexSignedContextOracleV1#427
hardyjosh merged 2 commits intomainfrom
feat/signed-context-oracle-meta-submodule

Conversation

@hardyjosh
Copy link
Copy Markdown
Contributor

@hardyjosh hardyjosh commented Feb 15, 2026

Caution

Merge order: Merge rain.metadata#92 first, then update the submodule pointer here to main before merging.

Motivation

The orderbook SDK needs SignedContextOracleV1 from rain.metadata to support oracle discovery for signed context data.

Solution

Updates the rain.metadata submodule to include the SignedContextOracleV1 metadata type (magic 0xff7a1507ba4419ca).

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

Summary by CodeRabbit

  • Chores
    • Updated internal library dependency.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 90d7c0e0-2f8d-49ad-a8e9-d4609f5a016e

📥 Commits

Reviewing files that changed from the base of the PR and between eb5a9ab and 487d3b4.

📒 Files selected for processing (1)
  • lib/rain.metadata
🚧 Files skipped from review as they are similar to previous changes (1)
  • lib/rain.metadata

📝 Walkthrough

Walkthrough

The pull request updates a git submodule reference in lib/rain.metadata, advancing the submodule from one commit to another. This is a version bump for the metadata library dependency without any changes to the primary codebase itself.

Changes

Cohort / File(s) Summary
Submodule Update
lib/rain.metadata
Submodule reference updated from commit a823381 to 355eae3.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop through the metadata maze,
We've bumped the submodule's phase,
From old commit to shiny new,
The reference refreshed, the binding true,
Dependencies dance in the lightest breeze! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the rain.metadata submodule to support RaindexSignedContextOracleV1, which aligns with the changeset that updates the submodule reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/signed-context-oracle-meta-submodule

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hardyjosh hardyjosh changed the title chore: update rain.metadata submodule for SignedContextOracleV1 feat: update rain.metadata submodule for SignedContextOracleV1 Feb 22, 2026
@hardyjosh hardyjosh changed the title feat: update rain.metadata submodule for SignedContextOracleV1 feat: update rain.metadata submodule for RaindexSignedContextOracleV1 Feb 22, 2026
@hardyjosh hardyjosh requested a review from findolor February 25, 2026 15:47
@hardyjosh hardyjosh force-pushed the feat/signed-context-oracle-meta-submodule branch from eb5a9ab to 487d3b4 Compare March 6, 2026 02:32
@hardyjosh hardyjosh merged commit 0e4284b into main Mar 7, 2026
10 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2026

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 7, 2026

Tip

For best results, initiate chat on the files or code changes.

SIZE=S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants