feat: add move method to pages endpoint#307
Merged
ramnes merged 2 commits intoramnes:mainfrom Dec 18, 2025
Merged
Conversation
- Add pages.move() method to move pages to new parents - Add test_move_pages with mocked API calls - Follows existing code patterns in the project Implements move page functionality from JS SDK
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 424 426 +2
=========================================
+ Hits 424 426 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ramnes
requested changes
Dec 17, 2025
Owner
ramnes
left a comment
There was a problem hiding this comment.
Hey, thanks for this! Can you not mock but use a cassette instead, just like the other tests around? We have a few mocks for very specific use cases but I don't need we need them here.
Contributor
Author
|
Hi I updated to use VCR tests with real API calls instead of mocks. Ready for review! |
ramnes
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
pages.move()method to move Notion pages to new parent locations.Changes
move()method toPagesEndpointclassPATCH /pages/{page_id}endpointtest_move_pageswith mocked API callsTesting
✅ All tests pass (125 passed)
✅ Coverage remains at 100%
✅ Pre-commit hooks pass
References