Merged
Conversation
Contributor
|
gonna wait to rebase this after #2864 |
Contributor
Author
|
Rebased, updated, and force-pushed. |
because IMHO float2fix64_4c is more readbale than float2fix644c
but only when one of the relevant files changes
Contributor
Author
|
Now split into smaller (more granular) commits to hopefully make the changes easier to review. |
kilograham
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Find and fix a bunch of common mistakes in
test/pico_float_test/custom_float_funcs_test.candtest/pico_float_test/custom_double_funcs_test.cA more comprehensive follow-up to the things I was spotting in #2849 and #2853