Repository navigation
refactor: use color for intent and variant for style - #976
Merged
Merged
Conversation
Badge, Indicator, Text, Link, AnnouncementBar and timeline markers move variant to color. Callout moves type to color and keeps variant. warning becomes attention, alert and error become danger, and grey, normal and default become neutral (Callout normal becomes primary). Spinner default becomes inherit. Separator color takes emphasis and the intents.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedToo many files! This PR contains 111 files, which is 11 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
|
commit: |
This was referenced Oct 19, 2026
Shreyag02
approved these changes
Oct 25, 2026
# Conflicts: # apps/www/src/content/docs/(overview)/upgrading.mdx # packages/react/components/indicator/indicator.tsx
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
colorholds the intent andvariantholds only the visual style.Badge,Indicator,Text,Link,AnnouncementBarand theDataView.Timelinemarkersmovevarianttocolor.Calloutmovestypetocolorand keepsvariant(solid,outline).warningbecomesattention(Badge,Indicator,Chip),alertanderrorbecomedanger(Callout,AnnouncementBar), andgrey,normalanddefaultbecomeneutral(Callout,AnnouncementBar, timeline markers).Calloutnormalbecomesprimary.Spinnercolor="default"becomescolor="inherit".Separatorcoloralso takesemphasis,accent,attention,dangerandsuccess.Part of #650.
Breaking change: see the "
colorholds the intent" section of the upgrading page.Choices made in this PR:
Calloutcolor="neutral"withvariant="solid",AnnouncementBarcolor="neutral",Linkcolor="accent",BadgeandIndicatorcolor="accent",Spinnercolor="neutral".Separatorintent colors use the--rs-color-border-<intent>-primarytokens, andemphasisuses--rs-color-border-base-emphasis.data-colorin place ofdata-variant.Toasttype="warning"is a Base UI toast type, so it does not change.type="info"andtype="warn"on four callouts.Calloutnever had these values, so the callouts had no background. They now usecolor="neutral"andcolor="attention".docs/V1-migration.mdand the RFCs keep the old names, because they record past releases.Left out:
BadgeandSeparatorsizes, which #975 changes, and theBadgeandCallouticonrename, which is a separate change.